https://bugzilla.redhat.com/show_bug.cgi?id=846879 --- Comment #2 from Patrick Uiterwijk <puiterwijk@xxxxxxxxx> --- The first things I notice when looking at it (formal review will come later today): 1. You use both %{version} and $RPM_BUILD_ROOT, so inconsistent variable style usage. 2. The first changelog entry ("* Wed Jul 05 2006 Damien Miller <djm@xxxxxxxxxxx>") is not in the correct format: it is missing the version number. 3. The Url field should be in complete capitals, so "URL". -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review