Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ogdi - Open Geographic Datastore Interface https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222039 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-02-10 06:15 EST ------- I may be wrong, but from my reading of config/common.mak and of the makefile it seems that config/Linux.mak is already used, and not config/linux.mak, since TARGET=Linux. So the cp -af are unneeded. As a suggestion, I think it is more readable to avoid the {..,..} in the cp (although it may be less elegant). Also cp -p should in general be better suited than cp -af. make %{?_smp_mflags} fails for me. am I right in thinking that objects in /usr/lib/ogdi/ are dlopened? In that case it would be better if they hadn't a soname. /usr/lib/libecs_tcl.so.1 is in the main package, I guess this is a mistake. README-BIN.TXT is certainly unusefull. The requires for other subpackages should generally be with full version, ie: Requires: %{name} = %{version}-%{release} Why isn't the sed 's/\"projects.h\"/\<projects.h\>/g' a patch instead? It is not a blocker, but I suggest to do patches when possible since sed one liners fail without notice. I also suggest using rm instead of rm -f when possible such that it breaks if the files to remove aren't there anymore. Alternatively you can use %exclude in %files. I would also remove the -f to mv. In the pkgconfig file, there is certainly some .private requires or flags missing, for expat, zlib and proj. And the -devel subpackage depends certainly on zlib-devel, expat-devel and proj-devel. There is a scary amount of compiler warnings most of them seem serious. Maybe you could try to work patches for upstream? There is a Requires on pkgconfig for -devel missing. It seems to be a matter of style, but the template defattr is %defattr(-,root,root,-) If there are some examples, maybe their codes could be in %doc in -devel? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review