https://bugzilla.redhat.com/show_bug.cgi?id=846661 --- Comment #7 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Now builds in mock Issues: 1. in the %files section of the devel package, you've listed the shared object twice 2. Please confirm to one macro style: either RPM_BUILD_ROOT or %{buildroot} 3. Please version the Requires in the devel sub package 4. No need to repeat docs in devel 5. It is preferred if you use the %{name} macro instead of "libmatenotify" throughout the spec. It makes it easier to follow, reduces chances of spelling errors etc. 6. Similarly, in the Source0 URL, you can use %{version} instead of 1.4. That will make it easier while updating the package in the future. The rest looks good. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review