https://bugzilla.redhat.com/show_bug.cgi?id=846661 --- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- [+] OK [-] NA [?] Issue [+] Package meets naming and packaging guidelines [+] Spec file matches base package name. [?] Spec has consistent macro usage. Please use either $RPM_BUILD_ROOT or %{buildroot}, not both. [+] Meets Packaging Guidelines. [+] License [+] License field in spec matches [+] License file included in package See if you can request upstream to correct the FSF address in the next release? Not really a blocker, but an important change. [ankur@ankur libmatenotify-1.4.0]$ !find find . -name "*" -execdir licensecheck '{}' \; | sed -e '/UNKNOWN/ d' -e '/GENERATED FILE/ d' ./tests/test-replace-widget.c: *No copyright* LGPL (with incorrect FSF address) ./tests/test-basic.c: LGPL (v2.1 or later) (with incorrect FSF address) ./tests/test-multi-actions.c: LGPL (with incorrect FSF address) ./tests/test-server-info.c: LGPL (v2.1 or later) (with incorrect FSF address) ./tests/test-replace.c: *No copyright* LGPL (with incorrect FSF address) ./tests/test-xy-actions.c: LGPL (v2.1 or later) (with incorrect FSF address) ./tests/test-urgency.c: LGPL (with incorrect FSF address) ./tests/test-error.c: LGPL (v2.1 or later) (with incorrect FSF address) ./tests/test-markup.c: LGPL (v2.1 or later) (with incorrect FSF address) ./tests/test-xy.c: LGPL (v2.1 or later) (with incorrect FSF address) ./tests/test-xy-stress.c: LGPL (with incorrect FSF address) ./tests/test-image.c: LGPL (with incorrect FSF address) ./tests/test-size-changes.c: LGPL (v2.1 or later) (with incorrect FSF address) ./tests/test-rtl.c: LGPL (v2.1 or later) (with incorrect FSF address) ./tests/test-default-action.c: LGPL (v2.1 or later) (with incorrect FSF address) ./test-replace-widget.c: *No copyright* LGPL (with incorrect FSF address) ./test-basic.c: LGPL (v2.1 or later) (with incorrect FSF address) ./test-multi-actions.c: LGPL (with incorrect FSF address) ./test-server-info.c: LGPL (v2.1 or later) (with incorrect FSF address) ./test-replace.c: *No copyright* LGPL (with incorrect FSF address) ./test-xy-actions.c: LGPL (v2.1 or later) (with incorrect FSF address) ./test-urgency.c: LGPL (with incorrect FSF address) ./test-error.c: LGPL (v2.1 or later) (with incorrect FSF address) ./test-markup.c: LGPL (v2.1 or later) (with incorrect FSF address) ./test-xy.c: LGPL (v2.1 or later) (with incorrect FSF address) ./test-xy-stress.c: LGPL (with incorrect FSF address) ./test-image.c: LGPL (with incorrect FSF address) ./test-size-changes.c: LGPL (v2.1 or later) (with incorrect FSF address) ./test-rtl.c: LGPL (v2.1 or later) (with incorrect FSF address) ./test-default-action.c: LGPL (v2.1 or later) (with incorrect FSF address) ./tools/notify-send.c: LGPL (v2.1 or later) (with incorrect FSF address) ./notify-send.c: LGPL (v2.1 or later) (with incorrect FSF address) ./libmatenotify/internal.h: LGPL (v2.1 or later) (with incorrect FSF address) ./libmatenotify/notification.c: LGPL (v2.1 or later) (with incorrect FSF address) ./libmatenotify/notify.h: LGPL (v2.1 or later) (with incorrect FSF address) ./libmatenotify/notification.h: LGPL (v2.1 or later) (with incorrect FSF address) ./libmatenotify/notify.c: LGPL (v2.1 or later) (with incorrect FSF address) ./internal.h: LGPL (v2.1 or later) (with incorrect FSF address) ./notify-features.h.in: GPL (v2 or later) (with incorrect FSF address) ./notification.c: LGPL (v2.1 or later) (with incorrect FSF address) ./notify.h: LGPL (v2.1 or later) (with incorrect FSF address) ./notification.h: LGPL (v2.1 or later) (with incorrect FSF address) ./notify.c: LGPL (v2.1 or later) (with incorrect FSF address) [ankur@ankur libmatenotify-1.4.0]$ [+] Spec in American English [+] Spec is legible. [+] Sources match upstream md5sum: [ankur@ankur SPECS]$ review-md5check.sh libmatenotify.spec Getting http://pub.mate-desktop.org/releases/1.4/libmatenotify-1.4.0.tar.xz to /tmp/review/libmatenotify-1.4.0.tar.xz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 55276 100 55276 0 0 18668 0 0:00:02 0:00:02 --:--:-- 21251 2d2636ea02de669cf8a8e6163d43186b /tmp/review/libmatenotify-1.4.0.tar.xz 2d2636ea02de669cf8a8e6163d43186b /home/ankur/rpmbuild/SOURCES/libmatenotify-1.4.0.tar.xz removed `/tmp/review/libmatenotify-1.4.0.tar.xz' removed directory: `/tmp/review' [ankur@ankur SPECS]$ [-] Package needs ExcludeArch [+] BuildRequires correct [-] Spec handles locales/find_lang [-] Package is relocatable and has a reason to be. [+] Package is code or permissible content. [-] Doc subpackage needed/used. [+] Packages %doc files don't affect runtime. [-] Headers/static libs in -devel subpackage. [-] Spec has needed ldconfig in post and postun [?] .pc files in -devel subpackage/requires pkgconfig Package needs to Requires: pkgconfig? [+] .so files in -devel subpackage. [?] -devel package Requires: %{name} = %{version}-%{release} Please add Requires: %{name}%{?_isa} = %{version}-%{release} to the devel subpackage [+] .la files are removed. [-] Package is a GUI app and has a .desktop file [?] Package compiles and builds on at least one arch. Doesn't build in mock for me with a rawhide-x86_64 configuration. Mock log attached. [+] Package has no duplicate files in %files. [+] Package doesn't own any directories other packages own. [?] Package owns all the directories it creates. 1. The %{_includedir}/libmatenotify directory is unowned. Either add %dir %{_includedir}/libmatenotify to the %files section, or simple use %{_includedir}/libmatenotify which takes the directory and all its contents. 2. Similarly, the %{_datadir}/gtk-doc/html/libmatenotify/* directory is unowned. Remove the "*" at the end or add a %dir %{_datadir}/gtk-doc/html/libmatenotify/* line. [-] No rpmlint output. Didn't build. PENDING [-] final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm [-]qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) Didn't build. PENDING SHOULD Items: [?] Should build in mock. Fails [-] Should build on all supported archs [-] Should function as described. [-] Should have sane scriptlets. [-] Should have subpackages require base package with fully versioned depend. [+] Should have dist tag [+] Should package latest version [-] check for outstanding bugs on package. (For core merge reviews) Issues: 1. Some unowned directories must be corrected. 2. Package does not build, please look into this 3. Add pkgconfig to Requires 4. Devel subpackage should require main package 5. Macro usage needs to be consistent I don't think you need to have a BR: mate-common for the main package and then again for the devel subpackage. Once for the main package, it gets pulled in anyway. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review