https://bugzilla.redhat.com/show_bug.cgi?id=841662 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx --- Comment #4 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- (In reply to comment #3) > I am curious about some of the changes I needed to make to have the %setup > -q -c work. Because of that line I had to do cd Cairo-%{version} in > basically every section including the %files for documentation. I looked at > the %setup macros but didn't find anything that would what was needed. I > hope this is okay the way it is. Not really sure. Yes, this is ok (the only solution I know, and used by others pear/pecl extensions, as documented in the Guidelines) You don't need to use pre-version release (0.3). Version 0.3.2 is the final published version (even if state is "beta", but this is about code stability, not about versionning). See xdebug for pre-version example http://pecl.php.net/package/xdebug. => Release 1%{?dist} I would prefer you to create to cairo.ini in %prep and install it in %install This is cleaner, and make simpler if you need it twice (if one day, you choose to also build the zts extension). Just a cosmetic change. %defattr(-,root,root,-) is EL-5 only, should be removed %global php_apiver .. is not used, should be removed > - Own php/etc/cairo dir => typo : /usr/include/php/ext/cairo But this dir must be owned by -devel. So, this is enough: %{_includedir}/php/ext/%{pecl_name} Have you test build under various version / arch ? When I first build this extension, few month ago, I notice some test failure ? Will do the formal review soon. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review