[Bug 845021] Review Request: rubygem-openshift-origin-auth-mongo - OpenShift plugin for mongo authentication service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=845021

Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tcallawa@xxxxxxxxxx

--- Comment #7 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> ---
Does this need the non rubygem subpackage? The guidelines state that this is no
longer needed:

https://fedoraproject.org/wiki/Packaging/Ruby#Packaging_for_Gem_and_non-Gem_use

There is also this from rpmlint:

rubygem-openshift-origin-auth-mongo.noarch: W: wrong-file-end-of-line-encoding
/usr/share/gems/doc/openshift-origin-auth-mongo-0.8.5/ri/cache.ri

Should be easy to fix (sed -i 's/\r//' $FILE).

rubygem-openshift-origin-auth-mongo.noarch: W: unexpanded-macro
/usr/share/gems/doc/openshift-origin-auth-mongo-0.8.5/ri/Swingshift/MongoAuthService/user_exists%3f-i.ri
%3f

I _think_ this is a false positive, because the file name contains "%3f", but
you should check to ensure that filename is correct, it seems odd.

Everything else seems okay here, resolve these issues and I will finish this
review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]