https://bugzilla.redhat.com/show_bug.cgi?id=840037 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx --- Comment #6 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- A few items here: * You've still got one %define, please replace it with %global. * You're packaging an Apache HTTPD configuration file. Does this package need to have an explicit Requires: httpd ? * You should avoid using macros in comments or changelog entries. Just use %%foo instead of %foo, that will keep rpm from trying to eval them and will silence rpmlint. Everything else looks very clean and in keeping with the Guidelines. If you make those changes, I will finish off a review. (I note that you're looking for a sponsor, but I believe someone was willing to sponsor you as soon as 839064 is done). -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review