https://bugzilla.redhat.com/show_bug.cgi?id=846133 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |a.badger@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |a.badger@xxxxxxxxx Flags| |fedora-review+ --- Comment #4 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> --- APPROVED 45bd466b0a67acd168d67ea43482264c71f126d8ebe879041da674df79322610 WebOb-1.2.1.zip Good: * Naming follows the naming guidelines * License is MIT in source and spec. * No license file is present in the source * Spec file is legible * Source matches upstream * No locale files * Not an ELF shared library * No bundled libraries * Not relocatable * Package owns all directories it creates * Permissions set properly * Macros used consistently * Code, not content * No large doc * Things in %doc do not affect package runtime * Not a GUI app * Does not own files owned by other packages * All filenames valid utf-8 * Builds in koji for f17 and el6. Does not build for f18 but this is not intended for f18/rawhide. = Cosmetic = * It's just a matter of style but when including a directory in the %files sections, it's good to add a trailing "/". That way future maintainers know that you intentionally matched a directory there. = rpmlint = $ rpmlint *rpm *.spec (17:15:17):2959 python3-webob1.2.noarch: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize python-webob1.2.noarch: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize python-webob1.2.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize 3 packages and 1 specfiles checked; 0 errors, 3 warnings. We actually mean accessors here so this is a false positive. = Notes = * You should open a ticket with the webob upstream to include a license file. It's possible the webob package maintainer has already done this so search upstreanm's issue tracker to see. * In F18+ We probably want to bump the main python-webob package to latest and ship a python-webob1.1 (or python-webob1.0) backwards compat package for TG2 to use. This package is fine for EPEL5/6 and F17 or less though (since it is an API change so we shouldn't be bumping the main python-webob package on nay of those.) * Since the previous versions of python-webob don't work with python3, the python3 module doesn't need to be shipped as a compat module. It could be just python3-webob and could be installed normally (using python3 setup.py install). Disadvantage would be that it has a different build within the package. Advantage would be that users of the python3 package could simply do: import webob instead of having to setup the pythonpath using pkg_resources. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review