Bug 226366: Merge Review: regexp Product: Fedora Extras Version: devel Component: Package Review Andrew Overholt <overholt@xxxxxxxxxx> has granted Vivek Lakshmanan <vivekl@xxxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226366 ------- Additional Comments from Andrew Overholt <overholt@xxxxxxxxxx> (In reply to comment #6) > > > X source files match upstream > > > . I can't find the tarball. Also, Source0 can be the actual URL ending with the > > > tar.gz. > > Really? > > Sorry, I accidentally copied that from another review :) The md5sums match. > > > X BuildRequires are proper > > > . why is jpackage-utils in Requires(pre,post)? > > According to the guidelines, all directories created by the package must be > > owned by the package > > Yes, I agree with your reasoning but let's just remove the javadoc symlinking in > %post{,un} and then these requirements can go away. Okay, this isn't holding up the review, but I still don't like it :). > > > X final provides and requires are sane > > > Do we need a 'java' dependency somewhere? Does the (erroneous, I think) > > > Requires(pre,post) on jpackage-utils imply a regular Requires on it? Do we > > > need things in coreutils (rpm, ln) in Requires(post,postun)? > > Added the Requires on java I asked about the Requires(x) on coreutils things and the answer was to err on the safe side so those are fine. I don't like the JPackage-style %{__rm} but again, that's not going to hold up the review. APPROVED. Thanks, Vivek! As per https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225928#c7 , please rebuild this package in Brew and when I've confirmed that the updated package has hit Rawhide, I'll close this bug as RAWHIDE. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review