https://bugzilla.redhat.com/show_bug.cgi?id=835170 --- Comment #5 from Michael Scherer <misc@xxxxxxxx> --- So : - there is lots of stuff to remove for Fedora ( since it use systemd, I assume this is not gonna go to EPEL for now ) - Buildroot is not needed - %clean is not needed either - why is the file named /lib/systemd/system/irqbalance.service for cgdcdxd ? ( ie, it does conflict with existing one ) - typo in the summary ( mangement ) - Requires: libcgroup libmnl no need to explicitely requires that, as rpm will take care of this - you should either use $RPM_BUILD_ROOT or %buildroot, but do not mix both ( http://fedoraproject.org/wiki/Packaging/Guidelines#macros ) - you need to ship the COPYING file in %doc, since that's the license ( and so should be distributed along the rpm ) - the systemd policy should be followed https://fedoraproject.org/wiki/Packaging:Systemd like using %unitdir, using scriptlet to make sure systemd is aware of the new unit file - tarball download should be documented ( ie, https://fedoraproject.org/wiki/Packaging:SourceURL ) I am doing a more formal review once I tested the software :) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review