Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: regexp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226366 ------- Additional Comments From overholt@xxxxxxxxxx 2007-02-09 14:28 EST ------- (In reply to comment #5) > (In reply to comment #2) > > MUST: > > X rpmlint on regexp srpm gives no output > > W: regexp non-standard-group Development/Libraries/Java > > Perhaps: System Environment/Libraries ? > It seems use of the existing group is acceptable: > https://www.redhat.com/archives/fedora-packaging/2007-February/msg00070.html Okay. > > X source files match upstream > > . I can't find the tarball. Also, Source0 can be the actual URL ending with the > > tar.gz. > Really? Sorry, I accidentally copied that from another review :) > > X BuildRequires are proper > > . why is jpackage-utils in Requires(pre,post)? > According to the guidelines, all directories created by the package must be > owned by the package Yes, I agree with your reasoning but let's just remove the javadoc symlinking in %post{,un} and then these requirements can go away. > > X package owns all directories and files > > . why is the javadoc symlink not just made in %install and then added to the > > %file section? > Fixed. The %pre and %post scriptlets for the javadoc are there for multiple > versions of the javadoc package to coexist and the unversioned symlink allows > crosslinking of javadocs. I don't think this is worth the complexity of the the %posts. Do you agree? > > X final provides and requires are sane > > Do we need a 'java' dependency somewhere? Does the (erroneous, I think) > > Requires(pre,post) on jpackage-utils imply a regular Requires on it? Do we > > need things in coreutils (rpm, ln) in Requires(post,postun)? > Added the Requires on java Great, thanks. > As far as the > question of /bin/rm and /bin/ln in the requires(x) is concerned, this is to > ensure that rpm transactions ensure these are present before the > installation/uninstallation of the package since the %pre and %postun scripts > use them. Yeah, I'm just not sure if things in coreutils need to be worried about for Requires(post,postun). I'll ask on fedora-packaging and we can go from there. Thanks, Vivek. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review