https://bugzilla.redhat.com/show_bug.cgi?id=787517 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@xxxxxxxx | |m Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m --- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Successful scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4361345 Some initial comments: The source file headers of the gtk engine contain the GPLv2, please add it to the license declaration of your package. Drop libtool from BuildRequires, because it is needed by gnome-common anyway. %defattr is only needed if you want to provide your package for EPEL <6. Wouldn't it be better to provide the gtk engine in a separate package, including the gtk2 themes? The other stuff could also go into a noarch subpackage. Moreover, I'm unsure if dawati-backgrounds.xml needs an extra runtime requirement. For now, the binary package needs the following: libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libcairo.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 I'm missing metacity here. Maybe the package should be split into even more subpackages. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review