https://bugzilla.redhat.com/show_bug.cgi?id=839071 Haïkel Guémar <karlthered@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |karlthered@xxxxxxxxx --- Comment #2 from Haïkel Guémar <karlthered@xxxxxxxxx> --- 1. please remove this snippet CFLAGS="$RPM_OPT_FLAGS" 2. set version checks for dependencies (setup.py may contain such informations) 3. have you considered adding a %check section ? Flask add-ons often have extensive unit tests suite and it is strongly recommand that you run them. If some fails due to the chroot environment, you may disable them or make the whole suite not fail the build (the output will remain visible in logs so it's still useful). The same goes for https://bugzilla.redhat.com/show_bug.cgi?id=839097 https://bugzilla.redhat.com/show_bug.cgi?id=839097 As soon as the points above will be fixed, i'll run the formal review -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review