[Bug 752169] Review Request: zukitwo - Themes for GTK+2, GTK+3, Metacity, GNOME Shell and Xfwm4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=752169

--- Comment #62 from Mattia M. <mattia.meneguzzo+fedora@xxxxxxxxx> ---
By the way, just to avoid wasting disk space, I've replaced the copy of the
"gnome-shell" directory inside "Zukitwo-Dark" with a symlink to that placed
inside "Zukitwo". Rpmlint doesn't complain and the package installs and works
fine.

(In reply to comment #61)
> A more cosmetic issue is having multiple requirement i a single line, it
> makes it hard to read, I would prefer that you add one require line for each
> requirement.
> 
> Ex.
> 
> Requires:       %{name}-common = %{version}-%{release}, gtk-murrine-engine
> >= 0.98.1.1 gtk2-engines
> 
> should be.
> 
> Requires:       %{name}-common = %{version}-%{release}
> Requires:       gtk-murrine-engine >= 0.98.1.1
> Requires:       gtk2-engines
> 
> It also make git diff easier to read when doing updates to requirement

I've already submitted the package to Koji; I'm going to do that cosmetic
changed in the next release.
Thanks for your help!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]