https://bugzilla.redhat.com/show_bug.cgi?id=841662 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx --- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- quick notes 1/ from http://fedoraproject.org/wiki/Packaging/PHP > The source archive contains a package.xml outside any directory, > so you have to use use > %setup -q -c 2/ You must own %{_includedir}/php/ext/cairo 3/ > BuildRequires: php-devel >= 5.1.0 > Requires: php-devel%{?_isa} >= 5.4.0 Why 5.1.0 and 5.4.0 ? (upstream says 5.1.6) 4/ No need to requires php-common (abi check is enough) 5/ Do you really to plan EPEL-5 ? AFAIK, this package requires cairo >= 1.4 (so should BR cairo-devel >= 1.4) which is not available in EL-5. Dropping EL-5 target will allow a lot of cleanups. 6/ Please run provided test suite in %check, something like TEST_PHP_EXECUTABLE=%{_bindir}/php \ REPORT_EXIT_STATUS=1 \ NO_INTERACTION=1 \ %{_bindir}/php run-tests.php \ -n -q \ -d extension_dir=modules \ -d extension=%{pecl_name}.so -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review