https://bugzilla.redhat.com/show_bug.cgi?id=819099 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Mario, thanks for the comments. I've looked into gf2x's use of exit(). It occurs in one place, where it is a sanity check. That is, exit() is called only if internal data structures are in an inconsistent state. This is not good, of course. It would be much better to return some kind of error code to the caller. On the other hand, I don't see how to fix this easily without changing the library's API. I will write to upstream and suggest that they change their API to report the error to the caller instead of calling exit(). But I would like to proceed with this review, regardless, since this issue is not required to be resolved by the Fedora Packaging Guidelines. (I think; at least, I can't find where it is even mentioned in the guidelines. Correct me if I am wrong.) New URLs for a new upstream version: Spec URL: http://jjames.fedorapeople.org/gf2x/gf2x.spec SRPM URL: http://jjames.fedorapeople.org/gf2x/gf2x-1.1-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review