Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gnome-nettool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225827 dakingun@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dakingun@xxxxxxxxx Flag| |fedora-review- ------- Additional Comments From dakingun@xxxxxxxxx 2007-02-09 10:51 EST ------- Hi, NEEDSWORK: * Post and postun requires on desktop-file-utils are not necesary * why does it need to run 'update-desktop-database' in it post and postun, the desktop file deosn't seem to contain any mimetype key (admittedly, I only checked src/gnome-nettool.desktop.in) * The '--add-category X-Red-Hat-Base' can also be removed from the desktop-file-install, its redundant. * Packaging guildelines discourage using the '%makeinstall' macro (see http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review