Bug 225826: Merge Review: gnome-netstatus Product: Fedora Extras Version: devel Component: Package Review Deji Akingunola <dakingun@xxxxxxxxx> has denied Deji Akingunola <dakingun@xxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225826 ------- Additional Comments from Deji Akingunola <dakingun@xxxxxxxxx> Hi, NEEDSWORK: * Fail to build in mock (rawhide x86_64), seems to need a BR on libxslt; << make[3]: Leaving directory `/builddir/build/BUILD/gnome-netstatus-2.12.0/help' xsltproc -o gnome-netstatus-C.omf --stringparam db2omf.basename gnome-netstatus --stringparam db2omf.format 'docbook' --stringparam db2omf.dtd "-//OASIS//DTD DocBook XML V4.1.2//EN" --stringparam db2omf.lang C --stringparam db2omf.omf_dir "/usr/share/omf" --stringparam db2omf.help_dir "/usr/share/gnome/help" --stringparam db2omf.omf_in "`pwd`/./gnome-netstatus.omf.in" `/usr/bin/pkg-config --variable db2omf gnome-doc-utils` C/gnome-netstatus.xml db2omf: Could not construct the OMF maintainer element. Add an author, corpauthor, editor, othercredit, or publisher element with the role attribute set to "maintainer" to gnome-netstatus.xml. make[2]: *** [gnome-netstatus-C.omf] Error 10 make[2]: Leaving directory `/builddir/build/BUILD/gnome-netstatus-2.12.0/help' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/gnome-netstatus-2.12.0' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.59866 (%build) >> * The BuildRoot tag is very short, it doesn't conform to the packaging guildelines * Is "Prereq: gtk2 >..." neccesary at all? And also the explicit Requires on gtk2, libglade2, libgnomeui, and gnome-panel * Not very sure about this (since the build failed for me half-way), does the build really depends on gnome-vfs2, maybe that BR ought to be gnome-vfs2-devel. * Packaging guildelines discourage the use of '%makeinstall' macro, but advises using 'make DESTDIR=$RPM_BUILD_ROOT install' instead. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review