[Bug 845319] Review Request: openshift-origin-cartridge-cron-1.4 - Embedded cron support for OpenShift

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=845319

--- Comment #1 from Michael Scherer <misc@xxxxxxxx> ---
Hi,

- why restart cron in %post ?

- %{cartridgedir}/info/ is unowned, so does 
%{_sysconfdir}/cron.minutely

- %config(noreplace) %{cartridgedir}/info/configuration/ 
while you explain why this is marked as config, ( and that's a perfectly good
reason ), could I suggest to try to make a link to /etc instead ( ie, put
config in /etc, and a link to this directory ) so someone doing backup of /etc
with tar/rsync/anything will not be taken by surprise ( ie discover too late
that config is missing ), and this would respect the policy without disrupting
too much the code ?

Other than that, this seems good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]