Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gnome-media https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225822 dakingun@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|dakingun@xxxxxxxxx |bnocera@xxxxxxxxxx Flag|fedora-review? |fedora-review+ ------- Additional Comments From dakingun@xxxxxxxxx 2007-02-09 09:52 EST ------- GOOD: * Build Ok in mock (x86_64) * License (GPL) and rpm Group tag OK * Naming meets the packaging guildlines * Spec file clean and legible * Handles locales correctly * Build dependencies properly listed * Source file matches upstream's 094a92f01a3581de7b3567f85320df7b gnome-media-2.17.90.tar.bz2 * Own its files and directories correctly rpmlint warnings/error: This can mostly be ignored [deji@agape reviews]$ rpmlint gnome-media-2.17.90-6.fc7.x86_64.rpm E: gnome-media obsolete-not-provided gnome W: gnome-media conffile-without-noreplace-flag /etc/gconf/schemas/CDDB-Slave2.schemas W: gnome-media conffile-without-noreplace-flag /etc/gconf/schemas/gnome-audio-profiles.schemas W: gnome-media conffile-without-noreplace-flag /etc/gconf/schemas/gnome-cd.schemas W: gnome-media conffile-without-noreplace-flag /etc/gconf/schemas/gnome-volume-control.schemas [deji@agape reviews]$ rpmlint gnome-media-2.17.90-6.fc7.src.rpm W: gnome-media unversioned-explicit-obsoletes gnome [deji@agape reviews]$ rpmlint gnome-media-devel-2.17.90-6.fc7.x86_64.rpm W: gnome-media-devel no-documentation However I wonder if it's not just OK to drop that Obsoletes on gnome, it seems superfluous of gnome-media to Obsolete gnome as it cannot also provide it (gnome). I believe you can fix that, so APPROVED. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review