https://bugzilla.redhat.com/show_bug.cgi?id=843029 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |volker27@xxxxxx Flags| |fedora-review+ --- Comment #7 from Volker Fröhlich <volker27@xxxxxx> --- There's a typo in the last paragraph of the description: "By default is uses" should be "By default it uses". Consider to change "waypoints", as mentioned below. Please check the permissions of the tarball archive and the spec file when you check in. dbus-devel is unnecessary. Please also read the comments in the review. With all of them addressed, the package is ready to go and therefore approved. I also built a scratch in Rawhide. Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== C/C++ ==== [x]: MUST Header files in -devel subpackage, if present. [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs. ==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [-]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package contains desktop file if it is a GUI application. [x]: MUST Package installs a %{name}.desktop using desktop-file-install if there is such a file. [-]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [-]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) GENERATED FILE", "UNKNOWN", "*No copyright* UNKNOWN", "*No copyright* GENERATED FILE" For detailed output of licensecheck see file: /tmp/foxtrotgps/licensecheck.txt [x]: MUST The spec file handles locales properly. [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. I ran it, but I have no GPS device at hand. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Scriptlets must be sane, if used. [x]: SHOULD SourceX / PatchY prefixed with %{name}. [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Rpmlint ------- Checking: foxtrotgps-1.1.1-2.fc16.src.rpm foxtrotgps-1.1.1-2.fc16.x86_64.rpm foxtrotgps-debuginfo-1.1.1-2.fc16.x86_64.rpm foxtrotgps.src: W: spelling-error %description -l en_US waypoints -> way points, way-points, appoints foxtrotgps.src: W: strange-permission foxtrotgps-1.1.1.tar.xz 0660L foxtrotgps.src: W: strange-permission foxtrotgps.spec 0660L foxtrotgps.src:97: W: macro-in-%changelog %{buildroot} foxtrotgps.src:97: W: macro-in-%changelog %{name} foxtrotgps.x86_64: W: spelling-error %description -l en_US waypoints -> way points, way-points, appoints foxtrotgps.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/foxtrotgps.schemas foxtrotgps.x86_64: W: no-manual-page-for-binary osb2foxtrot foxtrotgps.x86_64: W: no-manual-page-for-binary georss2foxtrotgps-poi foxtrotgps.x86_64: W: no-manual-page-for-binary poi2osm foxtrotgps.x86_64: W: dangerous-command-in-%pre rm foxtrotgps.x86_64: W: dangerous-command-in-%post rm 3 packages and 0 specfiles checked; 0 errors, 12 warnings. The dangerous commands stem from the properly used gconf macros. The schema file isn't considered configuration by other packages either. All other are either addressed at the top or not critical. Rpmlint (installed packages) ---------------------------- # rpmlint foxtrotgps-debuginfo foxtrotgps-debuginfo.x86_64: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- foxtrotgps-1.1.1-2.fc16.x86_64.rpm (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env /usr/bin/perl /usr/bin/python GConf2 gpscorrelate gpsd jhead libatk-1.0.so.0()(64bit) libbluetooth.so.3()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libcurl.so.4()(64bit) libexif.so.12()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgconf-2.so.4()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglade-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgps.so.19()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsqlite3.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) foxtrotgps-debuginfo-1.1.1-2.fc16.x86_64.rpm (rpmlib, GLIBC filtered): Provides -------- foxtrotgps-1.1.1-2.fc16.x86_64.rpm: foxtrotgps = 1.1.1-2.fc16 foxtrotgps(x86-64) = 1.1.1-2.fc16 foxtrotgps-debuginfo-1.1.1-2.fc16.x86_64.rpm: foxtrotgps-debuginfo = 1.1.1-2.fc16 foxtrotgps-debuginfo(x86-64) = 1.1.1-2.fc16 MD5-sum check ------------- http://www.foxtrotgps.org/releases/foxtrotgps-1.1.1.tar.xz : MD5SUM this package : 9c4fe0e145d44acaecea9f382cd90ce5 MD5SUM upstream package : 9c4fe0e145d44acaecea9f382cd90ce5 Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09 Command line :/usr/bin/fedora-review -n foxtrotgps External plugins: -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review