https://bugzilla.redhat.com/show_bug.cgi?id=844963 --- Comment #2 from Jon Stanley <jonstanley@xxxxxxxxx> --- In general a very simple spec that looks good, but seems somewhat weird. I guess I should ask what the intended use of this package is, because it looks like it uses storage stuff from pyanaconda, which would be a....strange way to get info, unless you are planning to be used *only* in the install path, but it seems that this module is more generally useful (and perhaps non-useful entirely in the install path). Moreover, I'm not sure that anaconda guarantees a stable API - so this could break without warning because of internal changes in Anaconda. But for a review: source filesmatch upstream: $ sha256sum cura-storage-0.1.tar.gz ../cura-storage-0.1.tar.gz 35ece7f998f37f1299c8c2cf02de4e31365fc2ee92cadf79e949308efdc10156 cura-storage-0.1.tar.gz 35ece7f998f37f1299c8c2cf02de4e31365fc2ee92cadf79e949308efdc10156 ../cura-storage-0.1.tar.gz : yes - package meets naming and versioning guidelines. notes = specfile is properly named, is cleanly written and uses macros consistently. Unless this is planned to be used on RHEL5, the top two macros are not necessary, See http://fedoraproject.org/wiki/Packaging:Python#Macros yes - dist tag is present. yes - license field matches the actual license. yes - license is open source-compatible. yes - license text included in package. yes - latest version is being packaged. yes - BuildRequires are proper. warning - compiler flags are appropriate. - the CFLAGS to setup.py isn't necessary since this is a noarch package. note - %clean is present. - See above. If this package is intended for RHEL5, then a %clean section is needed. If not, no problem and drop the python %defines's yes - package builds in mock. yes - package installs properly. rpmlint is silent. final provides and requires are sane: $ rpm -q --requires -p ~/Downloads/cura-storage-0.1-1.fc17.noarch.rpm anaconda cmpi-bindings-pywbem python(abi) = 2.7 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 sblim-cmpi-base rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -q --provides -p ~/Downloads/cura-storage-0.1-1.fc17.noarch.rpm cura-storage = 0.1-1.fc17 yes - owns the directories it creates. yes - doesn't own any directories it shouldn't. yes - no duplicates in %files. yes - file permissions are appropriate. yes - no scriptlets present. yes - code, not content. yes - documentation is small, so no -docs subpackage is necessary. yes - %docs are not necessary for the proper functioning of the package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review