https://bugzilla.redhat.com/show_bug.cgi?id=845115 Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@xxxxxxxxxxxxxxxxx --- Comment #1 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> --- Some drive-by comments: - you need an obsoletes: - no need to clean up the build-root any more - why did you remove the old changelog entries? They still belong to the package - defattrs not required - you should enable the tests in a %check section -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review