https://bugzilla.redhat.com/show_bug.cgi?id=845110 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #3 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- == Review == - rpmlint checks return: libpng12.src: W: spelling-error Summary(en_US) libpng -> sibling libpng12.src: W: spelling-error %description -l en_US libpng -> sibling libpng12.src: W: strange-permission libpng-1.2.49.tar.bz2 0444L libpng12.src: W: invalid-url Source0: ftp://ftp.simplesystems.org/pub/png/src/libpng-1.2.49.tar.bz2 <urlopen error ftp error: [Errno ftp error] 550 libpng-1.2.49.tar.bz2: No such file or directory> libpng12.x86_64: W: spelling-error Summary(en_US) libpng -> sibling libpng12.x86_64: W: spelling-error %description -l en_US libpng -> sibling libpng12-devel.x86_64: W: spelling-error Summary(en_US) libpng -> sibling libpng12-devel.x86_64: W: spelling-error %description -l en_US libpng -> sibling libpng12-devel.x86_64: W: no-manual-page-for-binary libpng-config libpng12-devel.x86_64: W: no-manual-page-for-binary libpng12-config All of these are safe to ignore... libpng12-devel.x86_64: E: rpath-in-buildconfig /usr/bin/libpng12-config lines ['43'] Even this one, it is a false positive. - package meets naming guidelines - package meets packaging guidelines - license (zlib) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (fbf8faa70ebca2ed2ee6df6f2249f4722517b581af5b6c3c71bbdaf925d5954e) - package compiles on Fedora 17 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review