https://bugzilla.redhat.com/show_bug.cgi?id=844154 --- Comment #5 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Please be patient if somebody picks up your review request ;) Here are my comments (based on your first package version): Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4348747 Interesting stuff from rpmlint (not the whole output): $ rpmlint -i -v * libmatekeyring.i686: I: checking libmatekeyring.i686: I: checking-url http://pub.mate-desktop.org (timeout 10 seconds) libmatekeyring.i686: E: incorrect-fsf-address /usr/share/doc/libmatekeyring-1.4.0/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. libmatekeyring.src: I: checking libmatekeyring.src: I: checking-url http://pub.mate-desktop.org (timeout 10 seconds) libmatekeyring.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 5) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. The old FSF address refers to almost all source files which have a license header, and the COPYING file itself. Not a review blocker, but worth to inform the upstream developers. To use either spaces or tabs leads to better readability of the spec file, independent from the tab width in ones text editor. I recommend to use spaces, as given from the rpmdev-newspec tool. One more issue: %doc %{_datadir}/gtk-doc/ The -devel package owns the folder /usr/share/gtk-doc/html, which is a problem, because it is already owned by the gtk-doc package. Change this line to %doc %{_datadir}/gtk-doc/html/* -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review