https://bugzilla.redhat.com/show_bug.cgi?id=820115 --- Comment #10 from Ryan Curtin <ryan@xxxxxxxxxxxx> --- (In reply to comment #9) > (In reply to comment #8) > > $ rpmlint -v leptonica.spec > > leptonica.spec: I: checking-url > > http://leptonica.googlecode.com/files/leptonica-1.69.tar.gz (timeout 10 > > seconds) > > leptonica.spec: W: invalid-url Source0: > > http://leptonica.googlecode.com/files/leptonica-1.69.tar.gz HTTP Error 404: > > Not Found > > 0 packages and 1 specfiles checked; 0 errors, 1 warnings. > > > > It seems like the actual package URL is a .tar.bz2. I made that > > substitution to perform the rest of the review and testing. > > It has a .tar.gz download. > See http://code.google.com/p/leptonica/downloads/list How bizarre; that 404'ed last night for me but it is working now. > > I think a patch should be used instead of the sed substitution; if the sed > > lines no longer become necessary (or perhaps even become harmful after > > upstream updates), sed will not fail. Patches, on the other hand, will > > throw errors and the problem is clear at buildtime and does not manifest as > > a bizarre runtime bug. I have seen some other reviews where people have > > suggested this (prefer patches to sed) but I can't find a particular > > guideline indicating it. So I guess this is just my opinion. :) > > This is actually the "offical" way to remove rpath. See: > > http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath Ah, I must be asleep at the wheel. That can't be patched easily because it's not modifying the sources, it's modifying the output of the configure script. Oops. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review