https://bugzilla.redhat.com/show_bug.cgi?id=844165 --- Comment #22 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- (In reply to comment #21) > No, I mean use foo.1.* , so if the spec is ported on another distribution > using lzma, or if Fedora start to use lzma, bz2 or something else, you will > have no change to make later. ok, i will change it > > And I do not understand why you have attached all those patches, my point > was they go against the spirit of the recommendation for patches : > https://fedoraproject.org/wiki/PackageMaintainers/WhyUpstream > > IE, now there is a new upstream, I think they should really take a look at > those patches and see if they are acceptable for them, or say if they reject > them. > > If they do not apply as such, I would take the source code without patch, > use patcher ( or git ), and try to apply them one by one, and record the > change with git add, and then inspect each patch to see if it look like the > old one, if it fixes the issue, if it doesn't introduce a new one ( > especially with patch that are applied with the fuzzy option, they can be > applied at the wrong location and introduce subtle bugs that upstream > developers will never reproduce because they do not have the same patch, > giving us a bad reputation ). I will do a test build for me without patches accept patch0, because otherwise i run in this error if someone use mdm (gdm fork) from my repo. http://forums.mate-desktop.org/viewtopic.php?f=8&t=14 patch is send to upstream https://github.com/mate-desktop/mate-window-manager/issues/2 I will ask upstream devs to apply them. Also, i will send the other patches to upstream, let see what they will say. # fedora specific patches Patch12: fresh-tooltips.patch and patches which only applied with fuzz=0 i will droped out in gernerally. @ > - %{_bindir}/marco-theme-viewer > why is it placed in -devel, as this sound like a useful tool for every day > usage ? Can i used it in that form after Mario's comment, or should i update the docomentation? New build comming soon. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review