[Bug 824478] Review Request: msp430mcu - Headers and linker scripts for MSP430 micro-controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=824478

--- Comment #3 from Robert Spanton <rspanton@xxxxxxxxxx> ---
Hi Richard,

> [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>      $RPM_BUILD_ROOT)
>      Note: Clean is needed only if supporting EPEL
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

Hmm.  The %clean section is already present and contains exactly that line.

> [!]: MUST Each %files section contains %defattr if rpm < 4.4
>      Note: defattr(....) present in %files section. This is OK if packaging
>      for EPEL5. Otherwise not needed
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions

The %files section has a %defattr line at the top...

> [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install.
>      Note: rm -rf is only needed if supporting EPEL5

The %install section has exactly that line at the top.

> [!]: SHOULD Latest version is packaged.

It's still the latest LTS release version.  

> Would be nice if in some point we can provide not only LTS releases but also 
> more recent versions. Do you think it would be feasible and worth the effort?

Here's what Peter Bigot, the mspgcc maintainer, has said the LTS releases are
for:

  Downstream packagers should publish only LTS releases, and should
  periodically check for new patches to be integrated into their packages
  (though I'll try to announce them periodically).

I would prefer to stick with the LTS releases, as these are the wishes of the
project.

Hopefully that addresses all the issues.

Cheers,

Rob

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]