[Bug 841001] Review Request: libmatewnck - MATE Desktop Window Navigator Construction Kit libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=841001

--- Comment #23 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> ---
(In reply to comment #20)
> (In reply to comment #17)
> > Updated. Please review.
> > 
> > Spec URL: http://vicodan.fedorapeople.org/matespec/libmatewnck.spec
> > SRPM URL:
> > http://vicodan.fedorapeople.org/materpms/srpms/libmatewnck-1.4.0-2.fc17.src.
> > rpm
> > Description: libmatewnck is Window Navigator Construction Kit, i.e. a
> > library to use for writing pagers and taskslists and stuff.
> > 
> > $ rpmlint libmatewnck.spec 
> > 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
> > 
> > $ rpmlint libmatewnck-1.4.0-2.fc17.x86_64.rpm 
> > libmatewnck.x86_64: W: no-manual-page-for-binary matewnckprop
> > libmatewnck.x86_64: W: no-manual-page-for-binary matewnck-urgency-monitor
> > 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> > $ rpmlint libmatewnck-devel-1.4.0-2.fc17.x86_64.rpm 
> > libmatewnck-devel.x86_64: W: no-dependency-on
> > libmatewnck/libmatewnck-libs/liblibmatewnck
> > libmatewnck-devel.x86_64: W: spelling-error %description -l en_US ibmatewnck 
> > libmatewnck-devel.x86_64: W: no-documentation
> > 1 packages and 0 specfiles checked; 0 errors, 3 warnings.
> > 
> > $ rpmlint libmatewnck-1.4.0-2.fc17.src.rpm 
> > 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> > 
> > 
> > F17 koji build:
> > http://koji.fedoraproject.org/koji/taskinfo?taskID=4344270
> > 
> > F18 koji build:
> > http://koji.fedoraproject.org/koji/taskinfo?taskID=4344273
> 
> Please rebase your spec (it's terrible)  i.e throw it away and use the one
> in comment#1.

Ok, here's a list of what's wrong 


1. %{_datadir}/gir-1.0/Matewnck-1.0.gir belongs in -devel
2. delete all .a & .la files in %install

add

find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'

3. don't specify un-needed explicit requires

Requires:    mate-common

You may need to add

Requires:         startup-notification

Please check this out.

4. missing requires on -devel package, add

Requires: %{name} = %{version}-%{release}


5. Move this to just before the %files section (cosmetic only)

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig


6. preserve the timestamps (recommend)


make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]