[Bug 844165] Review Request: mate-window-manager - Unobtrusive window manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=844165

--- Comment #21 from Michael Scherer <misc@xxxxxxxx> ---
No, I mean use foo.1.* , so if the spec is ported on another distribution using
lzma, or if Fedora start to use lzma, bz2 or something else, you will have no
change to make later.

And I do not understand why you have attached all those patches, my point was
they go against the spirit of the recommendation for patches :
https://fedoraproject.org/wiki/PackageMaintainers/WhyUpstream

IE, now there is a new upstream, I think they should really take a look at
those patches and see if they are acceptable for them, or say if they reject
them.

If they do not apply as such, I would take the source code without patch, use
patcher ( or git ), and try to apply them one by one, and record the change
with git add, and then inspect each patch to see if it look like the old one,
if it fixes the issue, if it doesn't introduce a new one ( especially with
patch that are applied with the fuzzy option, they can be applied at the wrong
location and introduce subtle bugs that upstream developers will never
reproduce because they do not have the same patch, giving us a bad reputation
).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]