Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gemdropx - Falling blocks puzzlegame https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226998 ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-02-09 04:04 EST ------- (In reply to comment #1) > Well, > > * BuildRequires > - Mockbuild fails on FC7 i386 (needs desktop-file-utils) > Oops, can't believe I forgot that, fixed. > * Documentation > - Please add other "README" files > I assume you mean INSTALL.txt ICON.txt and TODO.txt? INSTALL.txt and ICON.txt both contain installation instructions and thus should not be packaged. I've added TODO.txt > * Timestamps > - keep timestamps on image files and etc, i.e. use "cp -p" > or "install -p" > Fixed > * Desktop file entry > ----------------------------------------------------- > --add-category X-Fedora \ > ----------------------------------------------------- > is deprecated and should be removed. > > * Scriptlets > ----------------------------------------------------- > if [ -x %{_bindir}/gtk-update-icon-cache ]; then > ----------------------------------------------------- > is redundant because execution of non-existing file > simply exits with 127 and is ignored by || : I've been doing things like this for over a year now, I know there was some discussion about both of these but I never followed it close enough to learn the new guidelines, to busy with other Fedora stuff. I've read the new guidelines now, thanks for straightening me out on this -> Both fixed. Here is a new version with all this fixed: Spec URL: http://people.atrpms.net/~hdegoede/gemdropx.spec SRPM URL: http://people.atrpms.net/~hdegoede/gemdropx-0.9-2.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review