https://bugzilla.redhat.com/show_bug.cgi?id=844165 --- Comment #5 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- (In reply to comment #1) > Hi, > > there is a few thing to fix ( while waiting for mate-conf to be done ) : > > > - %define _default_patch_fuzz 999 > > this should be dropped. If there is a problem, the patch could be applied > incorrectly with issue that would be hard to debug. without that line building applying patches failed. At this point i will check if this patches are necessary and can drop safely. [rave@mother ~]$ rpmbuild -ba /home/rave/rpmbuild/SPECS/mate-window-manager.spec Ausführung(%prep): /bin/sh -e /var/tmp/rpm-tmp.5CicTY + umask 022 + cd /home/rave/rpmbuild/BUILD + LANG=C + export LANG + unset DISPLAY + cd /home/rave/rpmbuild/BUILD + rm -rf mate-window-manager-1.4.0 + /usr/bin/xz -dc /home/rave/rpmbuild/SOURCES/mate-window-manager-1.4.0.tar.xz + /bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd mate-window-manager-1.4.0 + /bin/chmod -Rf a+rX,u+w,g-w,o-w . + echo 'Patch #0 (Should-set-RestartStyleHint-to-RestartIfRunning-wh.patch):' Patch #0 (Should-set-RestartStyleHint-to-RestartIfRunning-wh.patch): + /bin/cat /home/rave/rpmbuild/SOURCES/Should-set-RestartStyleHint-to-RestartIfRunning-wh.patch + /usr/bin/patch -s -p1 -b --suffix .Should-set-RestartStyleHint-to-RestartIfRunning-wh --fuzz=0 1 out of 1 hunk FAILED -- saving rejects to file src/core/main.c.rej patch unexpectedly ends in middle of line This happens with patch 0, 19, 20 , 120, 24, 29 I understand your hint, what can i do to get patches work alternative? > Not to mention that %define should be replaced by %global > > > - why is there a -devel if it is not mean to be used and linked with ? > Either the description is misleading, or there is something using it. > > > - rm -rf $RPM_BUILD_ROOT > > this should be removed, that's not needed on fedora ( nor on any modern > distribution ) done > > - speaking of patches, they should be sent upstream ( ie, to mate, not to > gnome ), and if patch are unused, they should be dropped ( or properly > rediffed, if they do not apply ). And I think that patching to change defaut > is IMHO bad ( like workspaces.patch ), like changing the private API ( > Should-set-RestartStyleHint-to-RestartIfRunning-wh.patch ) > > There is also some patch that were seen as non working by gnome ( > http://bugzilla.gnome.org/show_bug.cgi?id=336750 ) I will talk about this in another post, accept workspaces.patch. i remove them because it is nonsense. > - %defattr(-,root,root,-) > is uneeded since a long time thx, for info done > > - %{_bindir}/marco-theme-viewer > why is it placed in -devel, as this sound like a useful tool for every day > usage ? extra post > > - %{_mandir}/man1/marco-theme-viewer.1.gz > I would recommend to use a joker instead of *.gz, so this would be less work > later if the extension is changed. You mean like this? %{_mandir}/man1/marco.*.gz %{_mandir}/man1/marco-message.*.gz done > > - the reason to run autogen.sh should be documented ( in this case, the > patch 19 ), so this would be removed once patch is merged upstream > autogen.sh is needed because all mate upstreams doesn't have configure or make files, only configure.in or .ac and make.in . I will documented it. NOCONFIGURE=1 to avoid double configure I don't understand what you mean with patch 19 > > - %{_datadir}/mate/wm-properties/ > wouldn't this directory end unowned in the end ? ( and so should be fixed ) I will change it to %{_datadir}/mate/wm-properties/marco-wm.desktop > > - the desktop-file should be validated in the spec : > https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file- > install_usage I will read this for understanding > > - BuildRequires: libtool automake autoconf gettext > BuildRequires: autoconf, automake, libtool, mate-common > > there is duplicate BuildRequires You right! I will change it, libtool i remove if current mate-common in stable. I've done a new starting point for this request http://raveit65.fedorapeople.org/Mate-Desktop/fc16/SPECS/mate-window-manager.spec http://raveit65.fedorapeople.org/Mate-Desktop/fc16/SRPM/mate-window-manager-1.4.0-2.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review