https://bugzilla.redhat.com/show_bug.cgi?id=842013 --- Comment #10 from Steve Dickson <steved@xxxxxxxxxx> --- (In reply to comment #9) > There is 2 rpmlint warning : > > nfsometer.x86_64: W: non-standard-group System Tools > > nfsometer.x86_64: E: no-binary > > You need to add Arch: noarch ( since that's a noarch rpm ), and fix the > group ( even if i am not sure of the status of the group in Fedora, as there > is no policy, I'm assuming you mean a "BuildArch: noarch" I changed the group to: "Group: Applications/System" > > The license tag is also wrong, should be GPLv2+ ( since there is a "or > later" clause ) The License is now: "License: GPLv2+" > > > > Running it show that it may use iozone and bonnie++, should they be added as > Requires or as a documentation somehwere ? ( also, it may need git, make, > tar and other stuff, so I am not sure on how to proceed there ) Those will be used if they exist... The README talks about which workloads exist by default and which ones are optional... So I think this is good to go... I believe I have all the rpmlint warnings removed: $ rpmlint nfsometer-1.1-1.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint nfsometer.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Spec file and source rpm have on http://steved.fedorapeople.org/nfsometer/ have been updated (and restorecon-ed ;-) ) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review