Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Path-Class - Cross-platform path specification manipulation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225367 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From panemade@xxxxxxxxx 2007-02-09 00:22 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. - URL is not working. + source files match when used as upstream url http://search.cpan.org/CPAN/authors/id/K/KW/KWILLIAMS/Path-Class-0.16.tar.gz 2416d2f5ed1a8a98525baea5c25e1c Path-Class-0.16.tar.gz - Change Source URL. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Provides: perl(Path::Class) = 0.16 perl(Path::Class::Dir) perl(Path::Class::Entity) perl(Path::Class::File) + make test t/01-basic.........ok t/02-foreign.......# Test 28 got: "dir/subdir" (t/02-foreign.t at line 68 *TODO*) # Expected: "/dir/subdir" # t/02-foreign.t line 68 is: ok $dir->as_foreign('Unix'), '/dir/subdir'; # Test 29 got: "" (t/02-foreign.t at line 69 *TODO*) # Expected: "1" # t/02-foreign.t line 69 is: ok $dir->as_foreign('Unix')->is_absolute, 1; ok 2/29 skipped: Can't test VMS code on other platforms t/03-filesystem....ok All tests successful, 2 subtests skipped. Files=3, Tests=158, 1 wallclock secs ( 0.27 cusr + 0.07 csys = 0.34 CPU) APPROVED. Change Source URL. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review