https://bugzilla.redhat.com/show_bug.cgi?id=844165 --- Comment #1 from Michael Scherer <misc@xxxxxxxx> --- Hi, there is a few thing to fix ( while waiting for mate-conf to be done ) : - %define _default_patch_fuzz 999 this should be dropped. If there is a problem, the patch could be applied incorrectly with issue that would be hard to debug. Not to mention that %define should be replaced by %global - why is there a -devel if it is not mean to be used and linked with ? Either the description is misleading, or there is something using it. - rm -rf $RPM_BUILD_ROOT this should be removed, that's not needed on fedora ( nor on any modern distribution ) - speaking of patches, they should be sent upstream ( ie, to mate, not to gnome ), and if patch are unused, they should be dropped ( or properly rediffed, if they do not apply ). And I think that patching to change defaut is IMHO bad ( like workspaces.patch ), like changing the private API ( Should-set-RestartStyleHint-to-RestartIfRunning-wh.patch ) There is also some patch that were seen as non working by gnome ( http://bugzilla.gnome.org/show_bug.cgi?id=336750 ) - %defattr(-,root,root,-) is uneeded since a long time - %{_bindir}/marco-theme-viewer why is it placed in -devel, as this sound like a useful tool for every day usage ? - %{_mandir}/man1/marco-theme-viewer.1.gz I would recommend to use a joker instead of *.gz, so this would be less work later if the extension is changed. - the reason to run autogen.sh should be documented ( in this case, the patch 19 ), so this would be removed once patch is merged upstream - %{_datadir}/mate/wm-properties/ wouldn't this directory end unowned in the end ? ( and so should be fixed ) - the desktop-file should be validated in the spec : https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage - BuildRequires: libtool automake autoconf gettext BuildRequires: autoconf, automake, libtool, mate-common there is duplicate BuildRequires -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review