https://bugzilla.redhat.com/show_bug.cgi?id=841766 --- Comment #5 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- Thanks! (In reply to comment #4) > - With this package, you again have a sed line. Please replace this with a > patch. Done. > [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at > the > beginning of %install. > Note: rm -rf would be needed if support for EPEL5 is required This package isn't intended for EL5. > [!]: MUST Package consistently uses macro is (instead of hard-coded directory > names). > Note: Using both %{buildroot} and $RPM_BUILD_ROOT Done. > [!]: MUST Requires correct, justified where necessary. > Note: Please add a comment why the %{?_isa} are needed This package is arch-dependent (due to installation into arch-dependent directory - %{_libdir}erlang/lib) so I have to obey Fedora guidelines for arch-specific packages. > [!]: MUST Useful -debuginfo package or justification otherwise. > Note: Please add a description to %global debug_package %{nil} please Done. Comment added. > [!]: SHOULD Latest version is packaged. > Note: 1.1.4 is release about a month ago Done. > [!]: SHOULD SourceX / PatchY prefixed with %{name}. > Note: Source0 (basho-riak_search-1.1.2-0-g31220b9.tar.gz) That's how GitHub names git snapshots. We can't do much here. New package: * http://peter.fedorapeople.org/erlang-riak_search.spec * http://peter.fedorapeople.org/erlang-riak_search-1.1.4-1.fc18.src.rpm Koji scratchbuild for Rawhide: * http://koji.fedoraproject.org/koji/taskinfo?taskID=4340192 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review