Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: autofs - A tool for automatically mounting and unmounting filesystems https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227631 ikent@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(ikent@xxxxxxxxxx) | ------- Additional Comments From ikent@xxxxxxxxxx 2007-02-09 00:00 EST ------- (In reply to comment #1) > > - rpmlint checks return: > > W: autofs no-url-tag > > Is there any? Not really. I registered autofs.net and started a wiki (wiki.autofs.net) but it needs quite a bit of care and attention. We could use it anyway. Have a look and see what you think. > > W: autofs unversioned-explicit-obsoletes autofs-ldap > The specfile contains an unversioned Obsoletes: token, which will match all > older, equal and newer versions of the obsoleted thing. This may cause update > problems, restrict future package/provides naming, and may match something it > was originally not inteded to match -- make the Obsoletes versioned if > possible. Not sure but I believe this was added when going from autofs version 3 to autofs version 4 and all versions of autofs-ldap needed to be obsoleted. Probably good to keep this. > > W: autofs macro-in-%changelog _xxx > Macros are expanded in %changelog too, which can in unfortunate cases lead > to the package not building at all, or other subtle unexpected conditions that > affect the build. Even when that doesn't happen, the expansion results in > possibly "rewriting history" on subsequent package revisions and generally > odd entries eg. in source rpms, which is rarely wanted. Avoid use of macros > in %changelog altogether, or use two '%'s to escape them, like '%%foo'. Done. > > W: autofs mixed-use-of-spaces-and-tabs (spaces: line 481, tab: line 102) > The specfile mixes use of spaces and tabs for indentation, which is a > cosmetic annoyance. Use either spaces or tabs for indentation, not both. Done. > > - Why define %version and %release? Aren't they are defined automatically? Yep. Removed them. > > - Consider Requires: chkconfig rather than Requires: /sbin/chkconfig, easier on > the depsolvers and unlikely to change. Similar for /bin/bash, others. Done. Removed leading path where possible. > > - %clean should just be: > rm -rf $RPM_BUILD_ROOT Yep. Done. > > > - exit 0 in %preun seems unneeded. I noticed that, but wasn't sure about it. It's been removed now. > > - %defattr should be: > %defattr(-,root,root,-) Fixed. > > - There's an empty %doc line. > > - Still need to ship %dir /misc? You don't with /net. Yep. Removed and removed. > > - This: > > %dir %{_libdir}/autofs > %{_libdir}/autofs/* > > could be: > > %{_libdir}/autofs/ Yep. Consolidated these. I've commited the changes as autofs-5.0.1-0.rc3.17 but haven't yet built the package, waiting any further feedback. The changes should be available at (when they get there): http://cvs.fedora.redhat.com/viewcvs/devel/autofs/ Thanks Ian -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review