[Bug 718317] Review Request: asforza4 - 4-in-a-row in a dockapp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=718317

--- Comment #8 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
After a long, long time I've picked up asforza4 again. Well, I'm playing the
game from time to time, but I don't use any plugins.

(In reply to comment #7)
> > The package builds now for both i386 and x86_64
> 
> Yes, partly. Unfortunately, the plugin binaries are not yet compiled on
> x86_64. As you can see in the build log [1], option -fPIC is still missing
> when calling gcc -shared. You should patch the Makefiles in the subfolders
> as mentioned in comment #1. If you need help with this, let me know.
I can't found any occurences of gcc -shared without $OPT within the
subfolders... In any case, there is a problem, because asforza4 crashes once I
try to use a plugin (I'm working on x86_64 now). 
> 
> In the previously attached patch, I forgot to adapt another line of file
> asforza4.c: Replace ASLIBDIR with ASDATADIR in line 2538 too. Otherwise, the
> app doesn't find the themes.
> 
Done.
> As a cosmetic improvement I suggest to use consistent patch filename
> extensions (.patch is probably the most common one).
> 
Done. Theming works perfectly now.

My idea for the final package: Let asforza4 be what it is, a game and only a
game. I would prefer to drop the plugin stuff from the package with %exclude.
Better I try to package some other dockapps to have a separate mail checker and
so on.

Latest files:
SPEC URL: http://mariobl.fedorapeople.org/Review/SPECS/asforza4.spec
SRPM URL:
http://mariobl.fedorapeople.org/Review/SRPMS/asforza4-2.10-4.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]