https://bugzilla.redhat.com/show_bug.cgi?id=844015 --- Comment #19 from raveit65 <chat-to-me@xxxxxxxxx> --- http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-8.fc18.src.rpm (In reply to comment #11) > (In reply to comment #10) > > Hi Wolfgang, > > > > Thanks for taking the time to help contribute to the work going in to MATE > > Desktop for Fedora. > > > > Some initial thoughts: > > > > Easy stuff: > > > > 1) Please update license to LGPLv2+ and GPLv2+ (run license check -r . in > > source folder) > > This is a must Done. > > 2) Please remove source1 > > This is allowed (show me the guideline that prohibits this) > > > 3) Please update URL to http://mate-desktop.org > > This is a must. done > > 4) Please remove specific versions from dependencies (see below). > > This is allowed and needed. (show me the guideline that prohibits this) Correct specific versions from dependencies as in configure.in > > 5) Please remove unneeded defines in top of spec file. > > This is a must. > > Change %defines to %global Done > > > 6) Please remove patches and submit them to upstream, or give a logical > > explanation of why they MUST be in this package. > > This is allowed. (show me the guideline that prohibits this) + add information to macro TODO: rpmlint errors remove of BuildRequires: utoconf automake libtool gettext if mate-common-1.4.0-6.fc16 is in stable -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review