Bug 226105: Merge Review: logwatch Product: Fedora Extras Version: devel Component: Package Review Kevin Fenzi <kevin@xxxxxxxxx> has denied Ivana Varekova <varekova@xxxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226105 ------- Additional Comments from Kevin Fenzi <kevin@xxxxxxxxx> 1. Removing them I guess is ok. Have you contacted upstream about distributing them at all? 2. good. ok. 3.1. %build added ok. 3.2. 644 on all the services looks good. ok. 3.3. The logwatch.pl links are still not relative... Suggest: Change: ln -s %{_datadir}/logwatch/scripts/logwatch.pl %{buildroot}%{_sysconfdir}/cron.daily/0logwatch ln -s %{_datadir}/logwatch/scripts/logwatch.pl %{buildroot}%{_sbindir}/logwatch to ln -s ../../%{_datadir}logwatch/scripts/logwatch.pl %{buildroot}%{_sysconfdir}/cron.daily/0logwatch ln -s ../../%{_datadir}logwatch/scripts/logwatch.pl %{buildroot}%{_sbindir}/logwatch 3.4. The "pix" file still has dos CR/FE endings... Suggest: %{__sed} -i 's/\r//' %{buildroot}%{_datadir}/logwatch/scripts/services/pix 3.5. ok. So, 3.3 and 3.4 are the only outstanding items I see... Once you have addressed these items (either by making the suggested changes, or by explaining why they don't make sense), please reassign this review back to me, and change the 'fedora-review' flag back to ? for me to take action. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review