[Bug 841418] Review Request: prey - Open-source anti-theft solution

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=841418

--- Comment #9 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to comment #7)
> and I wonder which OS dependant
> files you mean, as it is just a bunch of bash scripts?

The FHS defines datadir as "read-only architecture-independent data"

Note the "data" and "architecture-independent":

=> These files are arguably "non-arch-independent":
%attr(755, -, -) %{_datadir}/%{name}/platform/linux/functions
%attr(644, -, -) %{_datadir}/%{name}/platform/linux/prey-config.glade
%attr(755, -, -) %{_datadir}/%{name}/platform/linux/prey-config.py*
%attr(755, -, -) %{_datadir}/%{name}/platform/linux/settings
%attr(755, -, -) %{_datadir}/%{name}/platform/linux/bin/sendEmail

(The idea behind datadir (/usr/share) is them begin sharable between different
OSes/architectures, e.g. through nfs mounts)


=> Theses files are executable:
%attr(755, -, -) %{_datadir}/%{name}/platform/linux/functions
%attr(755, -, -) %{_datadir}/%{name}/platform/linux/prey-config.py*
%attr(755, -, -) %{_datadir}/%{name}/platform/linux/settings
%attr(755, -, -) %{_datadir}/%{name}/platform/linux/bin/sendEmail

They aren't data, they are executables and therefore do not belong into
%{_datadir} but should be placed into %{_libdir}/%{name} or
%{_libexecdir}/%{name}


That said, a simple solution would be to install all these files into
%{_libdir}/%{name} instead of %{_datadir}/%{name}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]