https://bugzilla.redhat.com/show_bug.cgi?id=818729 Brenton Leanhardt <bleanhar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bleanhar@xxxxxxxxxx --- Comment #2 from Brenton Leanhardt <bleanhar@xxxxxxxxxx> --- Hi Jon, This is a great start. I'd like to offer an informal review of this package. Here are the issues I noticed: For readabilty please place the 'Requires' and 'BuildRequires' on their own line. For the Ruby 1.9 requirement see http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_ABI. On a similar note, please BuildRequire ruby-devel. http://fedoraproject.org/wiki/Packaging:Ruby#Non-Gem_Packages Make sure you have worked with upstream to incorporate fix_rubywarrior.patch: http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment Also in rubywarrior.rb please I think we should ask for justification of the the monkey patching instead of patching rubywarrior. In my opinion this is very close to a bundled library. For more details on this issue please read: http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries In this particular instance the issue seems very minor so it may suffice to work with upstream to have them document contact with the rubywarrior project to have the needed modifications made but not to make this a blocker. However, fixing this will be better for both projects in the end. The comment in KidsRuby.sh is misleading. It says that users should run it from their home directory yet it's installed to /usr/bin/KidsRuby.sh. The most recent changelog entry is lacking proper contact information. When I ran rpmlint I saw the following: kidsruby.noarch: E: devel-dependency SDL_mixer-devel kidsruby.noarch: E: script-without-shebang /usr/share/kidsruby/public/js/jquery/jquery-1.6.2.min.js kidsruby.noarch: E: script-without-shebang /usr/share/kidsruby/public/js/jquery/jquery-ui-1.8.16.custom.min.js kidsruby.noarch: E: script-without-shebang /usr/share/kidsruby/public/css/blitzer/jquery-ui-1.8.16.custom.css kidsruby.noarch: E: script-without-shebang /usr/bin/KidsRuby.sh kidsruby.noarch: W: no-manual-page-for-binary KidsRuby.sh 1 packages and 0 specfiles checked; 5 errors, 1 warnings. The javascript ones are probably false negatives. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review