[Bug 823105] Review Request: erlang-riak_control - Admin UI for Riak

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=823105

--- Comment #6 from Peter Lemenkov <lemenkov@xxxxxxxxx> ---
(In reply to comment #5)
> Also, using sed to build is very dangerous, it could break things if not
> kept up-to-date with the sources.
> I would advice you to use a patch file, as this will just fail to apply if
> the upstream sources are changed.

Thanks for the sensible advice! I really didn't realise why sed might be a bad
idea.

Here are updated files:

* http://peter.fedorapeople.org/erlang-riak_control.spec
* http://peter.fedorapeople.org/erlang-riak_control-0.1.2-2.fc18.src.rpm

Changelog:

- Consistent usage of macros.
- Removed sed invocation (replaced by patch-file)
- Fully removed EL5-related junk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]