https://bugzilla.redhat.com/show_bug.cgi?id=838756 --- Comment #6 from Gerard Ryan <gerard@xxxxxxx> --- (In reply to comment #5) > The LICENSE file must be included in the SRPM and installed as %doc. > This is required by the point 4. of the license. It's already being installed as %doc, and by extension is included in the SRPM, right? > /usr/share/java/maven-indexer-core-cli.jar contains bundled libraries. > Please remove them. See: > http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries Done. The entire jar was bundled libs. Turns out that's what maven-shade-plugin does...I guess maven-shade-plugin shouldn't be used in any fedora packages in this case. > Packaging guidelines says "If the number of provided JAR files exceeds > two, you MUST place them into a sub-directory named %{name}." > Please obey this rule. See: > http://fedoraproject.org/wiki/Packaging:Java#Installation_directory Ah yeah, I (incorrectly) was looking at the draft guidelines, where the MUST is substituted for a CAN: https://fedoraproject.org/w/index.php?title=User:Akurtakov/JavaPackagingDraftUpdate#Installation_directory Anyway, the uber-jar is no longer being installed, so this no longer applies :) Spec URL: http://galileo.fedorapeople.org/maven-indexer/4.1.2-3/maven-indexer.spec SRPM URL: http://galileo.fedorapeople.org/maven-indexer/4.1.2-3/maven-indexer-4.1.2-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review