https://bugzilla.redhat.com/show_bug.cgi?id=842013 --- Comment #4 from Steve Dickson <steved@xxxxxxxxxx> --- (In reply to comment #3) > Build in mock fail : > > Exécution_de(%build): /bin/sh -e /var/tmp/rpm-tmp.E1njxS > + umask 022 > + cd /builddir/build/BUILD > + cd nfsometer-1.1 > + LANG=C > + export LANG > + unset DISPLAY > + /usr/bin/python setup.py build > Traceback (most recent call last): > File "setup.py", line 15, in <module> > from setuptools.command.install import install as _install > ImportError: No module named setuptools.command.install > > > I think a BR is missing ( like python2-devel, or python3-devel ) python-setuptools was missing... > > Also, I think the COPYING file should be in %doc, as well as README ( the > former for legal reason, the later for usabilty ) Done! > > As a side note, I usually recommend to have 1 line for each requires, this > permit to have IMHO better diff ( ie, +/- show the only change ) Good idea... Here the diff: diff .old/nfsometer.spec nfsometer.spec --- .old/nfsometer.spec 2012-07-20 21:13:39.911420286 +0000 +++ nfsometer.spec 2012-07-25 13:09:22.960228234 +0000 @@ -1,6 +1,6 @@ Name: nfsometer Version: 1.1 -Release: 0%{?dist} +Release: 1%{?dist} Summary: NFS Performance Framework Tool Group: System Tools @@ -8,7 +8,12 @@ License: GPLv2 URL: http://wiki.linux-nfs.org/wiki/index.php/NFSometer Source0: http://www.linux-nfs.org/~dros/nfsometer/releases/%{name}-%{version}.tar.gz -Requires: nfs-utils python-matplotlib numpy python-mako filebench +BuildRequires: python-setuptools +Requires: nfs-utils +Requires: python-matplotlib +Requires: numpy +Requires: python-mako +Requires: filebench %description NFSometer is a performance measurement framework for running workloads and @@ -30,8 +35,11 @@ NFS client implementations. #For noarch packages: sitelib %{python_sitelib}/* -%doc +%doc COPYING README %changelog +* Wed Jul 25 2012 Steve Dickson <steved@xxxxxxxxxx> 1.1-1 +- Incorporated review comments. + * Thu Jul 19 2012 Steve Dickson <steved@xxxxxxxxxx> 1.1-0 - Inital commit. http://steved.fedorapeople.org/nfsometer/ has been updated -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review