https://bugzilla.redhat.com/show_bug.cgi?id=841003 --- Comment #26 from Dan Mashal <dan.mashal@xxxxxxxxx> --- 4. MUST omit static libraries and libtool archives, ie, items that match %{_libdir}/lib*.a %{_libdir}/lib*.la (or provide justification why they warrant an exception) DONE 5. SHOULD own includedir subdirectories. One easy way to do that, is to just include: %{_includedir}/matecorba-2.0/ which will include it, and recursively everything under it DONE 6. SHOULD. this %{_bindir}/matecorba-linc-cleanup-sockets looks like something that ought to be in the main runtime pkg instead of -devel This is already in %files not %files devel. 7. -devel MUST have an arch'd dependency on the main pkg, use this instead: Requires: %{name}%{?_isa} = %{version}-%{release} DONE 8. MUST drop Requires: mate-common this is a BuildRequires only, not required for normal runtime use. DONE -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review