Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: perl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226276 ------- Additional Comments From tcallawa@xxxxxxxxxx 2007-02-08 16:58 EST ------- Review: This review is against the attached spec file (id=147701). I rewrote the spec file, cleaning up lots of ancient cruft. Good: - rpmlint checks return: W: perl devel-file-in-non-devel-package /usr/lib/perl5/5.8.8/i386-linux-thread-multi/auto/DynaLoader/DynaLoader.a (should be safe to ignore, I'm pretty sure the base perl needs this) W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.6/i386-linux-thread-multi/auto W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.6/i386-linux-thread-multi W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.7/i386-linux-thread-multi/auto W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/auto W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.5/i386-linux-thread-multi/auto W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.7/i386-linux-thread-multi W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.6 W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.7 W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.5 W: perl siteperl-in-perl-module /usr/lib/perl5/site_perl/5.8.8 Since this is perl, not a perl-module, these are all safe to ignore. W: perl-devel no-documentation W: perl-suidperl no-documentation Safe to ignore. E: perl-suidperl setuid-binary /usr/bin/sperl5.8.8 root 04711 E: perl-suidperl non-standard-executable-perm /usr/bin/sperl5.8.8 04711 E: perl-suidperl non-standard-executable-perm /usr/bin/sperl5.8.8 04711 Since this is suidperl, it will be setuid and have non-standard permissions. Safe to ignore. W: perl strange-permission filter-depends.sh 0775 Safe to ignore. W: perl unversioned-explicit-provides perl(VMS::Filespec) W: perl unversioned-explicit-provides perl(VMS::Stdio) W: perl unversioned-explicit-provides perl(:MODULE_COMPAT_5.8.5) W: perl unversioned-explicit-provides perl(:MODULE_COMPAT_5.8.6) W: perl unversioned-explicit-provides perl(:MODULE_COMPAT_5.8.7) W: perl unversioned-explicit-provides perl(:MODULE_COMPAT_5.8.8) W: perl unversioned-explicit-provides perl(:WITH_ITHREADS) W: perl unversioned-explicit-provides perl(:WITH_THREADS) W: perl unversioned-explicit-provides perl(:WITH_LARGEFILES) W: perl unversioned-explicit-provides perl(:WITH_PERLIO) These provides don't merit versions, IMHO. Safe to ignore. W: perl unversioned-explicit-provides perl(abbrev.pl) W: perl unversioned-explicit-provides perl(assert.pl) W: perl unversioned-explicit-provides perl(bigfloat.pl) W: perl unversioned-explicit-provides perl(bigint.pl) W: perl unversioned-explicit-provides perl(bigrat.pl) W: perl unversioned-explicit-provides perl(bytes_heavy.pl) W: perl unversioned-explicit-provides perl(cacheout.pl) W: perl unversioned-explicit-provides perl(complete.pl) W: perl unversioned-explicit-provides perl(ctime.pl) W: perl unversioned-explicit-provides perl(dotsh.pl) W: perl unversioned-explicit-provides perl(dumpvar.pl) W: perl unversioned-explicit-provides perl(exceptions.pl) W: perl unversioned-explicit-provides perl(fastcwd.pl) W: perl unversioned-explicit-provides perl(find.pl) W: perl unversioned-explicit-provides perl(finddepth.pl) W: perl unversioned-explicit-provides perl(flush.pl) W: perl unversioned-explicit-provides perl(ftp.pl) W: perl unversioned-explicit-provides perl(getcwd.pl) W: perl unversioned-explicit-provides perl(getopt.pl) W: perl unversioned-explicit-provides perl(getopts.pl) W: perl unversioned-explicit-provides perl(hostname.pl) W: perl unversioned-explicit-provides perl(importenv.pl) W: perl unversioned-explicit-provides perl(look.pl) W: perl unversioned-explicit-provides perl(newgetopt.pl) W: perl unversioned-explicit-provides perl(open2.pl) W: perl unversioned-explicit-provides perl(open3.pl) W: perl unversioned-explicit-provides perl(perl5db.pl) W: perl unversioned-explicit-provides perl(pwd.pl) W: perl unversioned-explicit-provides perl(shellwords.pl) W: perl unversioned-explicit-provides perl(stat.pl) W: perl unversioned-explicit-provides perl(syslog.pl) W: perl unversioned-explicit-provides perl(tainted.pl) W: perl unversioned-explicit-provides perl(termcap.pl) W: perl unversioned-explicit-provides perl(timelocal.pl) W: perl unversioned-explicit-provides perl(utf8_heavy.pl) W: perl unversioned-explicit-provides perl(validate.pl) These are all "file" provides. They don't have real versions, per se. IMHO, safe to ignore. W: perl unversioned-explicit-provides perl(Carp::Heavy) Same as above, no real versioning here. Safe to ignore W: perl unversioned-explicit-obsoletes perl-Filter-Simple W: perl unversioned-explicit-obsoletes perl-Time-HiRes These obsoletes were last seen in FC-4. The perl package has versioned provides. Safe to ignore, IMHO. W: perl patch-not-applied Patch39: perl-5.8.8-bz204679.patch This patch isn't done yet. That's why its not applied. The spec file is marked to reflect this. Safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (Artistic or GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - %check ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - devel requires base package n-v-r - debuginfo package has valid content Please make sure you're comfortable with this new packaging spec file, and if so, commit it, build it in rawhide. Once that's done, I'll approve this package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review