[Bug 841641] Review Request: rubygem-gearchanger-mcollective-plugin - GearChanger plugin for mcollective service

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=841641

--- Comment #1 from Troy Dawson <tdawson@xxxxxxxxxx> ---
Informal Review:
The spec file needs to match the rpm name.
Please rename gearchanger-mcollective-plugin.spec to
rubygems-gearchanger-mcollective-plugin.spec

Although you have these variables defined for older releases, you don't use
them when it is time to.  Please use
%{gem_instdir}
%{gem_docdir}
%{gem_cache}
%{gem_spec}

Also, for your definition, you should define gem_spec as 

  %{gem_dir}/specifications/%{gem_name}-%{version}.gemspec

For Source0, use http://mirror.openshift.com/ instead of
https://mirror.openshift.com/
Sometimes for the automated testing it doesn't like the https, and the http
works just fine.

>From rpmlint:
rubygem-gearchanger-mcollective-plugin.noarch: E: script-without-shebang
/usr/share/gems/gems/gearchanger-mcollective-plugin-0.1.1/lib/gea
rchanger-mcollective-plugin/gearchanger/mcollective_application_container_proxy.rb

Rpmlint Trivial Things:
mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 76)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]