Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: statserial https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wolfy@xxxxxxxxxxxxxxxxxx |twaugh@xxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-02-08 16:43 EST ------- - there is no URL tag; please provide one if possible - Package is marked as relocatable; since is a no-no (unless properly documented and justified), PREFIX should disappear - BuildRoot does not have the preferred value - Release tag should include %{dist} - %build does not honor $RPM_OPT_FLAGS - %build should use SMP flags. If it doesn't work, please add a comment - the dot at the end of Summary should be removed - the tar.gz includes the GPL v2 license, but the package claims license to be BSD; - the license file (COPYING) should be included in the binary rpm - I suggest including the provided phone_log script as %doc -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review