Bug 226436: Merge Review: statserial Product: Fedora Extras Version: devel Component: Package Review manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> has denied manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436 ------- Additional Comments from manuel wolfshant <wolfy@xxxxxxxxxxxxxxxxxx> - there is no URL tag; please provide one if possible - Package is marked as relocatable; since is a no-no (unless properly documented and justified), PREFIX should disappear - BuildRoot does not have the preferred value - Release tag should include %{dist} - %build does not honor $RPM_OPT_FLAGS - %build should use SMP flags. If it doesn't work, please add a comment - the dot at the end of Summary should be removed - the tar.gz includes the GPL v2 license, but the package claims license to be BSD; - the license file (COPYING) should be included in the binary rpm - I suggest including the provided phone_log script as %doc _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review